Weight name preservation for CrossAttention #945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Oct 9, 2023
Summary: 1. Make sure lowering_utils capture all constants, including submodule's. 2. Add name for fx2ait's conversion of Attention Modules. Differential Revision: D50060817
muchulee8
force-pushed
the
export-D50060817
branch
from
1030bdf
to
8531300
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Oct 9, 2023
Summary: Pull Request resolved: facebookincubator#945 1. Make sure lowering_utils capture all constants, including submodule's. 2. Add name for fx2ait's conversion of Attention Modules. Differential Revision: D50060817 fbshipit-source-id: 341f57ae6adef34ded9f151e5ea5be1351270c62
muchulee8
force-pushed
the
export-D50060817
branch
from
8531300
to
07ba689
Compare
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Oct 9, 2023
Summary: 1. Make sure lowering_utils capture all constants, including submodule's. 2. Add name for fx2ait's conversion of Attention Modules. Differential Revision: D50060817
muchulee8
force-pushed
the
export-D50060817
branch
from
07ba689
to
b095fe5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Oct 9, 2023
Summary: 1. Make sure lowering_utils capture all constants, including submodule's. 2. Add name for fx2ait's conversion of Attention Modules. Differential Revision: D50060817
muchulee8
force-pushed
the
export-D50060817
branch
from
b095fe5
to
d40320b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
Summary: 1. Make sure lowering_utils capture all constants, including submodule's. 2. Add name for fx2ait's conversion of Attention Modules. Reviewed By: khabinov Differential Revision: D50060817
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
muchulee8
force-pushed
the
export-D50060817
branch
from
d40320b
to
5fc5cfe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50060817 |
|
This pull request has been merged in 49e08d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D50060817