Add codemarkup.TargetUses for pp1.Define uses

Summary: This is sufficient for first level uses of #defines to be found via find-refs Reviewed By: phlalx Differential Revision: D48105515 fbshipit-source-id: 162adf784d6f861b86b348ee6946863bdb71b15b
facebookincubator · Aug 7, 2023 · 0b9175f · 0b9175f
1 parent a3ee732
commit 0b9175f
Show file tree

Hide file tree

Showing 14 changed files with 1,388 additions and 4 deletions.
diff --git a/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro.out b/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro.out
@@ -0,0 +1,15 @@
+[
+    "@generated",
+    [
+        {
+            "filepath": "test.cpp",
+            "range": {
+                "columnBegin": 14,
+                "columnEnd": 17,
+                "lineBegin": 25,
+                "lineEnd": 25
+            },
+            "repository": "test"
+        }
+    ]
+]
diff --git a/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro.query b/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro.query
@@ -0,0 +1,2 @@
+action: findReferenceRanges
+args: "test/pp/define/test2.h/FOO"
diff --git a/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro_2.out b/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro_2.out
@@ -0,0 +1,4 @@
+[
+    "@generated",
+    []
+]
diff --git a/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro_2.query b/glean/glass/test/regression/tests/cpp/findReferenceRanges_macro_2.query
@@ -0,0 +1,2 @@
+action: findReferenceRanges
+args: "test/pp/define/test.cpp/A"
diff --git a/glean/lang/clang/tests/regression/preprocessor/define_use.query b/glean/lang/clang/tests/regression/preprocessor/define_use.query
@@ -0,0 +1 @@
+query: pp1.DefineUse _
diff --git a/glean/lang/clang/tests/regression/preprocessor/ifdef/define_use.out b/glean/lang/clang/tests/regression/preprocessor/ifdef/define_use.out
@@ -0,0 +1,75 @@
+[
+  "@generated",
+  {
+    "key": {
+      "define": {
+        "key": {
+          "macro": { "key": "IFDEF1" },
+          "source": {
+            "file": { "key": "test.cpp" },
+            "lineBegin": 9,
+            "columnBegin": 9,
+            "lineEnd": 9,
+            "columnEnd": 14
+          }
+        }
+      },
+      "use": {
+        "key": {
+          "macro": { "key": "IFDEF1" },
+          "name": { "begin": 259, "end": 265 },
+          "definition": {
+            "file": { "key": "test.cpp" },
+            "line": 9,
+            "column": 9
+          },
+          "expand": false,
+          "source": {
+            "file": { "key": "test.cpp" },
+            "lineBegin": 12,
+            "columnBegin": 8,
+            "lineEnd": 12,
+            "columnEnd": 14
+          },
+          "nameSpan": { "start": 259, "length": 6 }
+        }
+      }
+    }
+  },
+  {
+    "key": {
+      "define": {
+        "key": {
+          "macro": { "key": "IFDEF2" },
+          "source": {
+            "file": { "key": "test.cpp" },
+            "lineBegin": 10,
+            "columnBegin": 9,
+            "lineEnd": 10,
+            "columnEnd": 14
+          }
+        }
+      },
+      "use": {
+        "key": {
+          "macro": { "key": "IFDEF2" },
+          "name": { "begin": 307, "end": 313 },
+          "definition": {
+            "file": { "key": "test.cpp" },
+            "line": 10,
+            "column": 9
+          },
+          "expand": false,
+          "source": {
+            "file": { "key": "test.cpp" },
+            "lineBegin": 18,
+            "columnBegin": 9,
+            "lineEnd": 18,
+            "columnEnd": 15
+          },
+          "nameSpan": { "start": 307, "length": 6 }
+        }
+      }
+    }
+  }
+]