Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace dist in git by diff comment #152

Merged
merged 13 commits into from
Jul 9, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 9, 2021

We added dist in git so that we can more easily review the impact css processing pipeline changes (postcss etc)

But in practice it's creating a lot of annoying conflicts in recent PRs that are not even updating the postcss setup.

This PR try to use another approach

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2021
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Size Change: 0 B

Total Size: 539 kB

ℹ️ View Unchanged
Filename Size
./packages/core/dist/css/default-dark/default-dark-rtl.css 78.2 kB
./packages/core/dist/css/default-dark/default-dark-rtl.min.css 54.5 kB
./packages/core/dist/css/default-dark/default-dark.css 78.2 kB
./packages/core/dist/css/default-dark/default-dark.min.css 54.5 kB
./packages/core/dist/css/default/default-rtl.css 77.4 kB
./packages/core/dist/css/default/default-rtl.min.css 53.9 kB
./packages/core/dist/css/default/default.css 77.4 kB
./packages/core/dist/css/default/default.min.css 53.9 kB
./packages/core/dist/js/alerts.js 409 B
./packages/core/dist/js/alerts.min.js 409 B
./packages/core/dist/js/button-groups.js 267 B
./packages/core/dist/js/button-groups.min.js 267 B
./packages/core/dist/js/dropdowns.js 1.01 kB
./packages/core/dist/js/dropdowns.min.js 1.01 kB
./packages/core/dist/js/menu.js 1.74 kB
./packages/core/dist/js/menu.min.js 1.74 kB
./packages/core/dist/js/navbar.js 926 B
./packages/core/dist/js/navbar.min.js 926 B
./packages/core/dist/js/pills.js 270 B
./packages/core/dist/js/pills.min.js 270 B
./packages/core/dist/js/radio-behavior.js 705 B
./packages/core/dist/js/radio-behavior.min.js 705 B
./packages/core/dist/js/tabs.js 267 B
./packages/core/dist/js/tabs.min.js 267 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for infima ready!

🔨 Explore the source changes: d737f1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/infima/deploys/60e81c83ede57100089063db

😎 Browse the preview: https://deploy-preview-152--infima.netlify.app

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for infima ready!

🔨 Explore the source changes: d7d07ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/infima/deploys/60e825d7616c7d00083a0a93

😎 Browse the preview: https://deploy-preview-152--infima.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Dist CSS Diff

@slorber
Copy link
Collaborator Author

slorber commented Jul 9, 2021

👍 should make the review easy without generating git conflicts @lex111

image

@slorber slorber merged commit 0d50f44 into master Jul 9, 2021
@lex111
Copy link
Contributor

lex111 commented Jul 9, 2021

Awesome idea, thanks!

@yangshun yangshun deleted the slorber/post-diff-comment branch July 11, 2021 16:35
@yangshun
Copy link
Contributor

This is a great idea! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants