-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace dist in git by diff comment #152
Conversation
Size Change: 0 B Total Size: 539 kB ℹ️ View Unchanged
|
✔️ Deploy Preview for infima ready! 🔨 Explore the source changes: d737f1a 🔍 Inspect the deploy log: https://app.netlify.com/sites/infima/deploys/60e81c83ede57100089063db 😎 Browse the preview: https://deploy-preview-152--infima.netlify.app |
✔️ Deploy Preview for infima ready! 🔨 Explore the source changes: d7d07ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/infima/deploys/60e825d7616c7d00083a0a93 😎 Browse the preview: https://deploy-preview-152--infima.netlify.app |
Dist CSS Diff |
👍 should make the review easy without generating git conflicts @lex111 |
Awesome idea, thanks! |
This is a great idea! :) |
We added dist in git so that we can more easily review the impact css processing pipeline changes (postcss etc)
But in practice it's creating a lot of annoying conflicts in recent PRs that are not even updating the postcss setup.
This PR try to use another approach