Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about a version number? #113

Closed
paullaffitte opened this issue Feb 9, 2021 · 2 comments
Closed

What about a version number? #113

paullaffitte opened this issue Feb 9, 2021 · 2 comments

Comments

@paullaffitte
Copy link

Hello,

I'm interested in using Katran to build a load-balancer, however, I don't feel very confident knowing that it's unversioned. I don't even know how to handle it. There is no changelog so I cannot know if there is a critical bug fix, or a breaking change if I use a newer version of the code.

Do you plan to release well defined versions in the future? Using Semantic Versioning 2.0.0 seems to be a good solution as most open-source projects are following this spec.

Thanks

@udippant
Copy link
Contributor

Thank you @paullaffitte for your interest in using Katran to build an LB.

We do not have any immediate plan to implement versioning. Part of the reason has to do with the way Katran consumes its dependencies (libraries such as folly, fizz, wangle etc) which are not versioned themselves. Also our internal setup does not naturally lend itself to this manner of versioning.

We really make efforts to ensure that we do not introduce API breaking changes ourselves. If we need to do so in future, we will communicate in advance (or perhaps revisit versioning).

However, there is still a possibility in terms of introducing incompatibility by virtue of using new features and APIs in BPF available only in newer Kernel versions, as raised in this issue #100.
We try to address that by:

  • making sure new features are opt-in for users
  • Also, we are currently working to add a framework internally that continuously tests the code path in multiple kernel versions (we'll update the issue and the README doc once we have finalized this).

As I mentioned earlier, while we do not have immediate plan for adding explicit versioning, we will revisit this if there's a compelling need for it.
Let us know if you have further questions.

@udippant
Copy link
Contributor

Closing this. Feel free to reopen if you have further questions.

facebook-github-bot pushed a commit that referenced this issue Feb 20, 2022
Summary:
Pull Request resolved: facebook/sapling#113

GitHub Actions was failing at apt-get stage,  error message suggested adding an apt-get update as remedy.  Added in this diff and it indeed works.

The actions build fails later on missing mio::net module when building mysql async, but that's unrelated to this change.

Reviewed By: farnz

Differential Revision: D34368662

fbshipit-source-id: f0a00da3ee740ae4443a328616e792ea615c922c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants