Implement RldBpDecoder::next() using fast bitunpacking

RldBpDecoder::next() will be used to decode repetition levels and definition levels for complex types (ARRAY and MAP).
facebookincubator · Nov 10, 2022 · 3c1e0ad · 3c1e0ad
1 parent d89acd0
commit 3c1e0ad
Show file tree

Hide file tree

Showing 11 changed files with 6,661 additions and 114 deletions.
diff --git a/velox/dwio/common/BitPackDecoder.cpp b/velox/dwio/common/BitPackDecoder.cpp
@@ -21,7 +21,7 @@ namespace facebook::velox::dwio::common {
 using int128_t = __int128_t;
 
 #if XSIMD_WITH_AVX2
-// Bit unpacking using BMI2 and AVX2.
+
 typedef int32_t __m256si __attribute__((__vector_size__(32), __may_alias__));
 
 typedef int32_t __m256si_u
@@ -165,14 +165,15 @@ int32_t decode1To24(
   return i;
 }
 
-} // namespace
-#endif
-
 #define WIDTH_CASE(width)                                                      \
   case width:                                                                  \
     i = decode1To24<width>(bits, bitOffset, rows.data(), numSafeRows, result); \
     break;
 
+} // namespace
+
+#endif
+
 template <typename T>
 void unpack(
     const uint64_t* bits,