Respect orderable constraint in ArgumentTypeFuzzer

facebookincubator · Oct 12, 2023 · 59b6675 · 59b6675
1 parent 26142de
commit 59b6675
Show file tree

Hide file tree

Showing 3 changed files with 87 additions and 1 deletion.
diff --git a/velox/expression/tests/ArgumentTypeFuzzer.cpp b/velox/expression/tests/ArgumentTypeFuzzer.cpp
@@ -48,14 +48,22 @@ void ArgumentTypeFuzzer::determineUnboundedTypeVariables() {
     // Random randomType() never generates unknown here.
     // TODO: we should extend randomType types and exclude unknown based
     // on variableInfo.
-    bindings_[variableName] = randType();
+    if (variableInfo.orderableTypesOnly()) {
+      bindings_[variableName] = randOrderableType();
+    } else {
+      bindings_[variableName] = randType();
+    }
   }
 }
 
 TypePtr ArgumentTypeFuzzer::randType() {
   return velox::randType(rng_, 2);
 }
 
+TypePtr ArgumentTypeFuzzer::randOrderableType() {
+  return velox::randOrderableType(rng_, 2);
+}
+
 bool ArgumentTypeFuzzer::fuzzArgumentTypes(uint32_t maxVariadicArgs) {
   const auto& formalArgs = signature_.argumentTypes();
   auto formalArgsCnt = formalArgs.size();

diff --git a/velox/expression/tests/ArgumentTypeFuzzer.h b/velox/expression/tests/ArgumentTypeFuzzer.h
@@ -71,6 +71,9 @@ class ArgumentTypeFuzzer {
 
   TypePtr randType();
 
+  /// Generates an orderable random type, including structs, and arrays.
+  TypePtr randOrderableType();
+
   const exec::FunctionSignature& signature_;
 
   TypePtr returnType_;

diff --git a/velox/expression/tests/ArgumentTypeFuzzerTest.cpp b/velox/expression/tests/ArgumentTypeFuzzerTest.cpp
@@ -326,4 +326,79 @@ TEST_F(ArgumentTypeFuzzerTest, unconstrainedSignatureTemplate) {
   ASSERT_EQ(argumentTypes[0]->childAt(0), argumentTypes[1]);
 }
 
+TEST_F(ArgumentTypeFuzzerTest, orderableConstraint) {
+  {
+    for (int i = 0; i < 100; ++i) {
+      auto signature = exec::FunctionSignatureBuilder()
+                           .orderableTypeVariable("T")
+                           .returnType("bigint")
+                           .argumentType("T")
+                           .build();
+      std::mt19937 seed{123456};
+      ArgumentTypeFuzzer fuzzer{*signature, nullptr, seed};
+      fuzzer.fuzzArgumentTypes(kMaxVariadicArgs);
+      ASSERT_TRUE(fuzzer.argumentTypes()[0]->isOrderable());
+    }
+  }
+
+  {
+    auto signature = exec::FunctionSignatureBuilder()
+                         .orderableTypeVariable("T")
+                         .returnType("T")
+                         .argumentType("T")
+                         .build();
+    testFuzzingFailure(signature, MAP(VARCHAR(), BIGINT()));
+    testFuzzingFailure(signature, ARRAY(MAP(VARCHAR(), BIGINT())));
+  }
+
+  {
+    auto signature = exec::FunctionSignatureBuilder()
+                         .orderableTypeVariable("T")
+                         .returnType("array(T)")
+                         .argumentType("array(T)")
+                         .build();
+
+    testFuzzingSuccess(signature, ARRAY(DOUBLE()), {ARRAY(DOUBLE())});
+    testFuzzingSuccess(
+        signature, ARRAY(ROW({DOUBLE()})), {ARRAY(ROW({DOUBLE()}))});
+    testFuzzingFailure(signature, MAP(VARCHAR(), BIGINT()));
+  }
+
+  {
+    auto signature = exec::FunctionSignatureBuilder()
+                         .typeVariable("T")
+                         .orderableTypeVariable("U")
+                         .returnType("row(T, U)")
+                         .argumentType("T")
+                         .argumentType("row(T,U)")
+                         .build();
+
+    testFuzzingSuccess(
+        signature,
+        ROW({MAP(BIGINT(), BIGINT()), BIGINT()}),
+        {MAP(BIGINT(), BIGINT()), ROW({MAP(BIGINT(), BIGINT()), BIGINT()})});
+
+    testFuzzingFailure(signature, ROW({BIGINT(), MAP(VARCHAR(), BIGINT())}));
+  }
+
+  {
+    auto signature = exec::FunctionSignatureBuilder()
+                         .typeVariable("T")
+                         .orderableTypeVariable("U")
+                         .returnType("row(T,U)")
+                         .argumentType("T")
+                         .argumentType("function(T,U)")
+                         .build();
+
+    testFuzzingSuccess(
+        signature,
+        ROW({MAP(BIGINT(), BIGINT()), BIGINT()}),
+        {MAP(BIGINT(), BIGINT()),
+         std::make_shared<FunctionType>(
+             std::vector<TypePtr>{MAP(BIGINT(), BIGINT())}, BIGINT())});
+
+    testFuzzingFailure(signature, ROW({BIGINT(), MAP(VARCHAR(), BIGINT())}));
+  }
+}
+
 } // namespace facebook::velox::test