Skip to content

Commit

Permalink
fix null input test
Browse files Browse the repository at this point in the history
  • Loading branch information
jinchengchenghh committed Feb 28, 2023
1 parent 845867c commit 82a36cf
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "velox/exec/tests/utils/PlanBuilder.h"
#include "velox/functions/prestosql/aggregates/tests/AggregationTestBase.h"
#include "velox/functions/sparksql/aggregates/Register.h"
// #include "velox/vector/tests/utils/VectorMaker.h"

namespace facebook::velox::functions::sparksql::aggregates::test {
namespace {
Expand Down Expand Up @@ -52,10 +53,8 @@ TEST_F(BloomFilterAggAggregateTest, bloomFilter) {

TEST_F(BloomFilterAggAggregateTest, emptyInput) {
auto vectors = {makeRowVector({makeFlatVector<int64_t>({})})};

auto expected = {
makeRowVector({makeNullableFlatVector<StringView>({std::nullopt})})};

auto expected = {makeRowVector(
{makeNullableFlatVector<StringView>({std::nullopt}, VARBINARY())})};
testAggregations(vectors, {}, {"bloom_filter_agg(c0, 5, 64)"}, expected);
}
} // namespace facebook::velox::functions::sparksql::aggregates::test

0 comments on commit 82a36cf

Please sign in to comment.