address comments

facebookincubator · Jul 19, 2023 · ce5b638 · ce5b638
1 parent 4d342f7
commit ce5b638
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/velox/docs/functions/spark/comparison.rst b/velox/docs/functions/spark/comparison.rst
@@ -6,7 +6,7 @@ Comparison Functions
 
     Returns true if x is within the specified [min, max] range
     inclusive. The types of all arguments must be the same.
-    Supported types are: TINYINT, SMALLINT, INTEGER, BIGINT, DOUBLE, REAL.
+    Supported types are: TINYINT, SMALLINT, INTEGER, BIGINT, DOUBLE, REAL, HUGEINT.
 
 .. spark:function:: equalnullsafe(x, y) -> boolean
 

diff --git a/velox/functions/sparksql/Comparisons.h b/velox/functions/sparksql/Comparisons.h
@@ -98,27 +98,27 @@ struct GreaterOrEqual : private Less<T> {
 std::shared_ptr<exec::VectorFunction> makeEqualTo(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeLessThan(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeGreaterThan(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeLessThanOrEqual(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 std::shared_ptr<exec::VectorFunction> makeGreaterThanOrEqual(
     const std::string& name,
     const std::vector<exec::VectorFunctionArg>& inputArgs,
-    const core::QueryConfig& /*config*/);
+    const core::QueryConfig&);
 
 inline std::vector<std::shared_ptr<exec::FunctionSignature>>
 comparisonSignatures() {