Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove Parquet thrift code from Arrow writer #11489

Closed
wants to merge 1 commit into from
Closed

refactor: Remove Parquet thrift code from Arrow writer #11489

wants to merge 1 commit into from

Conversation

minhancao
Copy link
Contributor

@minhancao minhancao commented Nov 9, 2024 •
edited by majetideepak
Loading

Fixes: #11400

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0193932
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6732593ae1bdfd0008c1d20d

@minhancao minhancao changed the title Remove generated code from Arrow vendor thrift Remove generated code from Apache Thrift Nov 11, 2024
@minhancao minhancao force-pushed the remove_parquet_arrow_writer_generated_code_with_thrift branch from d56a0a8 to 0193932 Compare November 11, 2024 19:21
@minhancao
Copy link
Contributor Author

@majetideepak Can you review this PR when you can? Thanks!

majetideepak
majetideepak approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @minhancao

@majetideepak
Copy link
Collaborator

@pedroerp any thoughts on this?

@majetideepak majetideepak changed the title Remove generated code from Apache Thrift Remove Parquet thrift generated code from Arrow writer copy Nov 12, 2024
@majetideepak majetideepak changed the title Remove Parquet thrift generated code from Arrow writer copy refactor: Remove Parquet thrift generated code from Arrow writer copy Nov 12, 2024
@majetideepak majetideepak changed the title refactor: Remove Parquet thrift generated code from Arrow writer copy refactor: Remove Parquet thrift code from Arrow writer Nov 12, 2024
@pedroerp
Copy link
Contributor

Makes sense to me. This has been in our todo list for a while; thanks for refactoring!

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 13, 2024
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in 5ab1a8f.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 5ab1a8f4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak majetideepak approved these changes

@pedroerp pedroerp Awaiting requested review from pedroerp

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Parquet writer arrow thrift generated code
4 participants
@minhancao @majetideepak @pedroerp @facebook-github-bot