Add week, week_of_year Presto functions #2287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Add documentation here https://facebookincubator.github.io/velox/functions/datetime.html. Can copy the description from |
velox/functions/prestosql/registration/DateTimeFunctionsRegistration.cpp
Outdated
Show resolved
Hide resolved
velox/functions/prestosql/registration/DateTimeFunctionsRegistration.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
week_func
branch
from
1414e72
to
6a57e20
Compare
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
pramodsatya
force-pushed
the
week_func
branch
from
6a57e20
to
51ca7de
Compare
pramodsatya
force-pushed
the
week_func
branch
2 times, most recently
from
2d58ea5
to
63a1e92
Compare
aditi-pandit
reviewed
Jan 3, 2023
mbasmanova
reviewed
Jan 4, 2023
mbasmanova
reviewed
Jan 5, 2023
mbasmanova
reviewed
Jan 5, 2023
mbasmanova
reviewed
Jan 5, 2023
mbasmanova
reviewed
Jan 5, 2023
mbasmanova
reviewed
Jan 5, 2023
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 99a0ec7. |
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Presto functions week and week_of_year (alias of week).