Fix memory pool dtor race in VeloxSubstraitRoundTripPlanConverterTest #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
sub
branch
2 times, most recently
from
744bf46
to
58eff60
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Oct 13, 2022
…acebookincubator#2828) Summary: This is caused by the async task deletion (task dtor triggered by async driver removal). The fix is to add memory counting wait in Substrait2VeloxValuesNodeConversionTest dtor. Pull Request resolved: facebookincubator#2828 Differential Revision: D40332245 Pulled By: xiaoxmeng fbshipit-source-id: 7b433274385b9ed0e08cec06cd658e2a5f012a62
|
This pull request was exported from Phabricator. Differential Revision: D40332245 |
xiaoxmeng
changed the title
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…facebookincubator#2828) Summary: This is caused by the async task deletion (task dtor triggered by async driver removal). The fix is to add memory counting wait in Substrait2VeloxValuesNodeConversionTest dtor. Pull Request resolved: facebookincubator#2828 Differential Revision: D40332245 Pulled By: xiaoxmeng fbshipit-source-id: 3344c92d57e98d38f3ba860c75125039b6c4b0b7
|
This pull request was exported from Phabricator. Differential Revision: D40332245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by the async task deletion (task dtor triggered by
async driver removal). The fix is to add memory counting wait in
Substrait2VeloxValuesNodeConversionTest dtor.