Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect orderable constraint in ArgumentTypeFuzzer #6950

Closed
wants to merge 1 commit into from
Closed

Respect orderable constraint in ArgumentTypeFuzzer #6950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion velox/expression/tests/ArgumentTypeFuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,22 @@ void ArgumentTypeFuzzer::determineUnboundedTypeVariables() {
// Random randomType() never generates unknown here.
// TODO: we should extend randomType types and exclude unknown based
// on variableInfo.
bindings_[variableName] = randType();
if (variableInfo.orderableTypesOnly()) {
bindings_[variableName] = randOrderableType();
} else {
bindings_[variableName] = randType();
}
}
}

TypePtr ArgumentTypeFuzzer::randType() {
return velox::randType(rng_, 2);
}

TypePtr ArgumentTypeFuzzer::randOrderableType() {
return velox::randOrderableType(rng_, 2);
}

bool ArgumentTypeFuzzer::fuzzArgumentTypes(uint32_t maxVariadicArgs) {
const auto& formalArgs = signature_.argumentTypes();
auto formalArgsCnt = formalArgs.size();
Expand Down
3 changes: 3 additions & 0 deletions velox/expression/tests/ArgumentTypeFuzzer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ class ArgumentTypeFuzzer {

TypePtr randType();

/// Generates an orderable random type, including structs, and arrays.
TypePtr randOrderableType();

const exec::FunctionSignature& signature_;

TypePtr returnType_;
Expand Down
77 changes: 77 additions & 0 deletions velox/expression/tests/ArgumentTypeFuzzerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,4 +326,81 @@ TEST_F(ArgumentTypeFuzzerTest, unconstrainedSignatureTemplate) {
ASSERT_EQ(argumentTypes[0]->childAt(0), argumentTypes[1]);
}

TEST_F(ArgumentTypeFuzzerTest, orderableConstraint) {
mbasmanova marked this conversation as resolved.
Show resolved Hide resolved
{
auto signature = exec::FunctionSignatureBuilder()
.orderableTypeVariable("T")
.returnType("bigint")
.argumentType("T")
.build();

for (size_t i = 0; i < 100; ++i) {
std::mt19937 rng(i);
ArgumentTypeFuzzer fuzzer{*signature, nullptr, rng};
fuzzer.fuzzArgumentTypes(kMaxVariadicArgs);
ASSERT_TRUE(fuzzer.argumentTypes()[0]->isOrderable())
<< fuzzer.argumentTypes()[0]->toString();
}
}

{
auto signature = exec::FunctionSignatureBuilder()
.orderableTypeVariable("T")
.returnType("T")
.argumentType("T")
.build();
testFuzzingFailure(signature, MAP(VARCHAR(), BIGINT()));
testFuzzingFailure(signature, ARRAY(MAP(VARCHAR(), BIGINT())));
}

{
auto signature = exec::FunctionSignatureBuilder()
.orderableTypeVariable("T")
.returnType("array(T)")
.argumentType("array(T)")
.build();

testFuzzingSuccess(signature, ARRAY(DOUBLE()), {ARRAY(DOUBLE())});
testFuzzingSuccess(
signature, ARRAY(ROW({DOUBLE()})), {ARRAY(ROW({DOUBLE()}))});
testFuzzingFailure(signature, MAP(VARCHAR(), BIGINT()));
}

{
auto signature = exec::FunctionSignatureBuilder()
.typeVariable("T")
.orderableTypeVariable("U")
.returnType("row(T, U)")
.argumentType("T")
.argumentType("row(T,U)")
.build();

testFuzzingSuccess(
signature,
ROW({MAP(BIGINT(), BIGINT()), BIGINT()}),
{MAP(BIGINT(), BIGINT()), ROW({MAP(BIGINT(), BIGINT()), BIGINT()})});

testFuzzingFailure(signature, ROW({BIGINT(), MAP(VARCHAR(), BIGINT())}));
}

{
auto signature = exec::FunctionSignatureBuilder()
.typeVariable("T")
.orderableTypeVariable("U")
.returnType("row(T,U)")
.argumentType("T")
.argumentType("function(T,U)")
.build();

testFuzzingSuccess(
signature,
ROW({MAP(BIGINT(), BIGINT()), BIGINT()}),
{MAP(BIGINT(), BIGINT()),
std::make_shared<FunctionType>(
std::vector<TypePtr>{MAP(BIGINT(), BIGINT())}, BIGINT())});

testFuzzingFailure(signature, ROW({BIGINT(), MAP(VARCHAR(), BIGINT())}));
}
}

} // namespace facebook::velox::test