Fix FunctionType::equivalent #6952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@xiaoxmeng Hi Xiaoxuan, could you please help review this PR? I found this issue when I tried to add UT at #6950. Thanks a lot. |
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 417e43f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: `FunctionType::equivalent` only works for `ScalarType` arguments, it returns wrong results when arguments are `ComplexType`, say `FUNCTION<ARRAY<BIGINT>, BOOLEAN>` vs. `FUNCTION<ARRAY<BIGINT>, BOOLEAN>` would return false if using this API. Pull Request resolved: facebookincubator#6952 Reviewed By: bikramSingh91 Differential Revision: D50072758 Pulled By: xiaoxmeng fbshipit-source-id: 04ad1dbe887553658e1c5d67a3132bea0b3c0f27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionType::equivalentonly works forScalarTypearguments,it returns wrong results when arguments are
ComplexType, sayFUNCTION<ARRAY<BIGINT>, BOOLEAN>vs.FUNCTION<ARRAY<BIGINT>, BOOLEAN>would return false if using this API.