Add tests for array-based joins #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbasmanova
requested review from
funrollloops,
kgpai,
pedroerp,
oerling and
amitkdutta
facebook-github-bot
added
the
CLA Signed
Add a test for hash join where build-side keys come from a small range and allow for array-based lookup instead of a hash table.
mbasmanova
force-pushed
the
test-join-valueids
branch
from
4d1e540
to
ef60a82
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 13c0fb2. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebookincubator/fizz#76 X-link: facebook/proxygen#402 X-link: facebook/folly#1735 X-link: facebookarchive/bistro#60 X-link: facebook/watchman#1012 X-link: facebook/fbthrift#487 X-link: facebook/fboss#114 X-link: facebook/fb303#27 When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/). This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment. Reviewed By: mackorone Differential Revision: D34696330 fbshipit-source-id: 06cae87eef40dfa3cecacacee49234b6737d546f
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
Summary: X-link: facebookincubator/fizz#76 X-link: facebook/proxygen#402 X-link: facebook/folly#1735 X-link: facebookarchive/bistro#60 X-link: facebook/watchman#1012 X-link: facebook/fbthrift#487 X-link: facebook/fboss#114 X-link: facebook/fb303#27 When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/). This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment. Reviewed By: mackorone Differential Revision: D34696330 fbshipit-source-id: 06cae87eef40dfa3cecacacee49234b6737d546f
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
* use the aligned function names with Substrait * add a writing function * use constant variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for hash join where build-side keys come from a small range
and allow for array-based lookup instead of a hash table.