Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar for epochs #184

Merged
merged 17 commits into from
Jan 8, 2021

Conversation

nicofirst1
Copy link
Contributor

Adding progress bar for epochs both in training and testing.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 12, 2020
egg/core/trainers.py Outdated Show resolved Hide resolved
egg/core/callbacks.py Outdated Show resolved Hide resolved
@robertodessi
Copy link
Contributor

Thanks, except minor comments it looks nice!

Nit: Do you know if rich is faster than tqdm or did you do any test? I mean rich-callback vs tqdm-callback or plain tqdm.

@nicofirst1
Copy link
Contributor Author

For a comparison between tqdm and rich you can refer to this issue

@robertodessi
Copy link
Contributor

yep I read those already but it mentions comparable performance for quick iterations, it'd be nice to check for long runs like your coco use case but I think it is not so important now, we can leave it as is

@nicofirst1
Copy link
Contributor Author

Is everything ok with this PR?
I have some updates but would like to create a new PR based on this one

egg/core/callbacks.py Outdated Show resolved Hide resolved
egg/core/trainers.py Outdated Show resolved Hide resolved
egg/core/callbacks.py Outdated Show resolved Hide resolved
egg/core/callbacks.py Outdated Show resolved Hide resolved
@robertodessi
Copy link
Contributor

Except these (very) minor comments it looks good to me! If @eugene-kharitonov agrees we could merge
Meanwhile you could branch out of your own branch and commit the updates there

egg/core/trainers.py Outdated Show resolved Hide resolved
@robertodessi robertodessi merged commit 24c61ad into facebookresearch:master Jan 8, 2021
@nicofirst1 nicofirst1 deleted the progress_bar branch January 9, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants