-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify yaml file reading for both OSS and fbcode #195
Conversation
This pull request was exported from Phabricator. Differential Revision: D64920545 |
…acebookresearch#194) Summary: ## What does this PR do? Fixes # 193 - Wrong Configuration Path Caused Test Failures This PR fixes four things in a previous diff. (1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into `pyproject.toml` file. ``` [[tool.mypy.overrides]] module = "yaml" ignore_missing_imports = true ``` (3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names" (4) Fix format warnings when importing sorces fbcode into github. ## Before submitting - [ x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [ ] N/A - [ ] Did you write any new necessary tests? - [x ] N/A - [ ] Did you make sure to update the docs? - [x ] N/A - [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)? - [ ] N/A Pull Request resolved: facebookresearch#194 Differential Revision: D64839500 Privacy Context Container: L1200110 Reviewed By: briancoutinho, sraikund16
This pull request was exported from Phabricator. Differential Revision: D64920545 |
7d17d5b
to
cbc4584
Compare
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
This pull request was exported from Phabricator. Differential Revision: D64920545 |
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
cbc4584
to
7737c4e
Compare
This pull request was exported from Phabricator. Differential Revision: D64920545 |
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
7737c4e
to
0727db6
Compare
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
This pull request was exported from Phabricator. Differential Revision: D64920545 |
0727db6
to
c0e8260
Compare
This pull request was exported from Phabricator. Differential Revision: D64920545 |
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
This pull request was exported from Phabricator. Differential Revision: D64920545 |
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
This pull request was exported from Phabricator. Differential Revision: D64920545 |
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
Summary: Unify yaml file reading for both OSS and fbcode
Differential Revision: D64920545