Unify yaml file reading for both OSS and fbcode #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
…acebookresearch#194) Summary: ## What does this PR do? Fixes # 193 - Wrong Configuration Path Caused Test Failures This PR fixes four things in a previous diff. (1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into `pyproject.toml` file. ``` [[tool.mypy.overrides]] module = "yaml" ignore_missing_imports = true ``` (3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names" (4) Fix format warnings when importing sorces fbcode into github. ## Before submitting - [ x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [ ] N/A - [ ] Did you write any new necessary tests? - [x ] N/A - [ ] Did you make sure to update the docs? - [x ] N/A - [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)? - [ ] N/A Pull Request resolved: facebookresearch#194 Differential Revision: D64839500 Privacy Context Container: L1200110 Reviewed By: briancoutinho, sraikund16
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
force-pushed
the
export-D64920545
branch
from
7d17d5b
to
cbc4584
Compare
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
niufei8888
force-pushed
the
export-D64920545
branch
from
cbc4584
to
7737c4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
niufei8888
force-pushed
the
export-D64920545
branch
from
7737c4e
to
0727db6
Compare
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
force-pushed
the
export-D64920545
branch
from
0727db6
to
c0e8260
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
|
This pull request was exported from Phabricator. Differential Revision: D64920545 |
niufei8888
added a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebookresearch#195 Unify yaml file reading for both OSS and fbcode Differential Revision: D64920545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Unify yaml file reading for both OSS and fbcode
Differential Revision: D64920545