Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quotes for better compatibility (REAMDE / ffmpeg) #245

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

starburst997
Copy link
Contributor

conda install 'ffmpeg<5' -c conda-forge will results with "The system cannot find the file specified." on Windows.

Using " (double quotes) provide better compatibility and results in the correct behavior on Windows.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2023
@starburst997 starburst997 changed the title Use double quotes for better compatibility Use double quotes for better compatibility (REAMDE / ffmpeg) Aug 23, 2023
@JadeCopet
Copy link
Contributor

Thanks for your contribution! Can you pull from main before we merge this PR? There was some issue with the transformer library that is currently breaking the tests and this is now fixed in main.

@starburst997
Copy link
Contributor Author

Of course, no problem, just did

Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JadeCopet JadeCopet merged commit b50c9a4 into facebookresearch:main Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants