Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing protobuf dependency #251

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix: add missing protobuf dependency #251

merged 2 commits into from
Aug 25, 2023

Conversation

0xlws
Copy link
Contributor

@0xlws 0xlws commented Aug 25, 2023

on my local machine trying to run the script results in he same error:
img
#241 (comment)

adding protobuf to the requirements solves this.

fixes: #241, #247

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2023
@JadeCopet JadeCopet self-requested a review August 25, 2023 11:10
JadeCopet
JadeCopet approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems that there is an issue with Hugging Face Transformers that expects it. This indeed solves the issue so let's add the dependency for now.

@JadeCopet JadeCopet merged commit 5ecdc68 into facebookresearch:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadeCopet JadeCopet JadeCopet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbound local error
3 participants
@0xlws @JadeCopet @facebook-github-bot