Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring #285

Closed
wants to merge 1 commit into from
Closed

Fix docstring #285

wants to merge 1 commit into from

Conversation

carlthome
Copy link
Contributor

@carlthome carlthome commented Sep 23, 2023 •
edited
Loading

Match actual argument name in docstring.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2023
@carlthome
Copy link
Contributor Author

Unrelated error on main?

JadeCopet
JadeCopet approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JadeCopet
Copy link
Contributor

Hi, if you can take the last changes from main, this would allow to fix the CI and merge the PR. Thanks

@carlthome
Copy link
Contributor Author

No, sorry, don't have time nor interest in doing that. Think you should rethink how you accept community contributions.

@carlthome carlthome closed this Nov 22, 2023
@carlthome carlthome deleted the patch-1 branch November 22, 2023 10:39
@JadeCopet
Copy link
Contributor

Ok i understand. Thanks for your contribution and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadeCopet JadeCopet JadeCopet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlthome @JadeCopet @facebook-github-bot