Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring #300

Closed
wants to merge 1 commit into from
Closed

Fix docstring #300

wants to merge 1 commit into from

Conversation

Drabble
Copy link

@Drabble Drabble commented Oct 5, 2023

Match the B acronym in codebooks_patterns.py docstring.

@facebook-github-bot
Copy link

Hi @Drabble!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2023
JadeCopet
JadeCopet approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your contribution

@JadeCopet
Copy link
Contributor

Can you make sure you have the latest changes from main so that the CI passes? Thanks

@Drabble
Fix docstring
c9b9d70 
Match the acronym in `codebooks_patterns.py`.
@Drabble
Copy link
Author

Drabble commented Nov 27, 2023

I have rebased my branch to the latest commit 👍

@JadeCopet
Copy link
Contributor

Addressed in v1.3.0.

@JadeCopet JadeCopet closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadeCopet JadeCopet JadeCopet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drabble @facebook-github-bot @JadeCopet