Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in diffusion solver config #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hadyelsahar
Copy link

What?

This is probably an issue with the config file for the diffusion model. The generation sample rate should be added to the generate and not in dataset.generate

This generate.audio params are passed to audio_write functions save audio using ffmpeg in the following line

audio_path = audio_write(stem_path, wav, **self.xp.cfg.generate.audio)

Test

python3 -m pdb -c c -m  dora run solver=diffusion/encodec_24khz execute_only=generate continue_from=/path_to_ckpt.th dset=audio/default

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants