Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Selector for IDMap #2848

Closed
wants to merge 1 commit into from
Closed

Support Selector for IDMap #2848

wants to merge 1 commit into from

Commits on May 8, 2023

  1. Support Selector for IDMap (facebookresearch#2848) 

    Summary:
Pull Request resolved: facebookresearch#2848

Add selector support for IDMap wrapped indices.
Caveat: this requires to wrap the IDSelector with another selector. Since the params are const, the const is casted away.

This is a problem if the same params are used from multiple execution threads with different selectors. However, this seems rare enough to take the risk.

Reviewed By: alexanderguzhva

Differential Revision: D45598823

fbshipit-source-id: d626595f335b4cd600a7b1d7fdd6744cba2a79dd
    @mdouze @facebook-github-bot
    mdouze authored and facebook-github-bot committed May 8, 2023
    Configuration menu
    Copy the full SHA
    3dd8948 View commit details
    Browse the repository at this point in the history