Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@package support #584

Merged
merged 14 commits into from
May 16, 2020
Merged

@package support #584

merged 14 commits into from
May 16, 2020

Conversation

omry
Copy link
Collaborator

@omry omry commented May 11, 2020

Closes #586
Closes #235

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2020
@omry omry changed the title parsing config header package support May 12, 2020
@omry omry force-pushed the package branch 3 times, most recently from 731aadc to 167db11 Compare May 13, 2020 18:28
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2020

This pull request introduces 1 alert when merging 7276808 into aa95958 - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

@omry omry changed the title package support @package support May 14, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 15, 2020

This pull request introduces 2 alerts when merging ac9e1b0 into aa95958 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 15, 2020

This pull request introduces 1 alert when merging 96afa9f into aa95958 - view on LGTM.com

new alerts:

  • 1 for Unused import

@omry omry merged commit 4170bc6 into master May 16, 2020
@omry omry deleted the package branch May 16, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
2 participants