Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try/finally in context manager #1383

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Use try/finally in context manager #1383

merged 1 commit into from
Mar 14, 2022

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Mar 14, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Clean-up was not performed in case of exception

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 14, 2022
@jrapin jrapin merged commit 527c727 into main Mar 14, 2022
@jrapin jrapin deleted the try_finally branch March 14, 2022 12:02
teytaud added a commit that referenced this pull request Mar 17, 2022
* adding multiscale to gp and sparse gp benchmark

* fix

* multiscale out of for loop

* NaN robustness in Gym (#1289)

* NaN robustness in Gym

* Update nevergrad/functions/gym/multigym.py

Co-authored-by: Jérémy Rapin <[email protected]>

* fix

* fix

Co-authored-by: Jérémy Rapin <[email protected]>

* Add more models for Gym control (#1346)

* more models for Gym control

* Update gymexperiments.py

* Update multigym.py

* fix

* Update gymexperiments.py

* update moremodels (#1378)

* Bump version to 0.4.3.post10 (#1364)

* Removing an incomplete sentence from the doc (#1367)

* Fix broken CI (#1370)

* docs: add GH button in support of Ukraine  (#1369)

* Add the FAO crop model (#1343)

* aquacrop

* fix

* fix

* fix

* Update ac.py

* black

* Update experiments.py (#1361)

* fix

* Update bench.txt

* fix

* fix

* fix

* tentative_pip3

* yet_another_tentative_fi

* yet_another_tentative_fi

* fix

* fix_suffering

* desperate_try

* desperate_try

* desperate_try

* desperate_try

* fix

* desperate_try

* desperate_try

* desperate_try

* desperate_try

* fix

* Update config.yml

* fix

* Update setup.py

* Update main.txt

* fix

* Use up-to-date headers (#1371)

* Add NLOPT as a solver (#1340)

* Update version and changelog to 0.5.0 (#1372)

* Deactivate mutation test in CI (#1374)

* Reduce noise in gym (#1333)

* Reduce noise in gym

* Update multigym.py

* Add comment

Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Dmitry Vinnik <[email protected]>

* fix

* fix

* im_lost

* fix

* fix

* fix

Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Dmitry Vinnik <[email protected]>

* Add a conformant GP experiment (#1337)

* Adding a conformant GP experiment

Because sometimes conformant planning, in spite of being super simple, performs incredibly well.

* fix

* High-speed differential evolution (#1366)

* High-speed differential evolution

* Update base.py

* Update optimizerlib.py

* fix

* fix

* clean

* clean

* Update differentialevolution.py

* Update nevergrad/optimization/differentialevolution.py

Co-authored-by: Jérémy Rapin <[email protected]>

* Update nevergrad/optimization/differentialevolution.py

Co-authored-by: Jérémy Rapin <[email protected]>

* fi

* fix

* fix

* fix

Co-authored-by: Jérémy Rapin <[email protected]>

* Use try/finally in context manager (#1383)

* Running PBO with both instrumentations (#1382)

* Fix by Risto (#1376)

* Fix by Risto

* Update corefuncs.py

* black

* Possibility to remove numerical suffixes (#1373)

* Possibility to remove numerical suffixes

* Update plotting.py

* fix

* Update plotting.py

* fix (#1384)

* new high-speed cma (#1381)

* newhscma

* fix

* anti_flaky

* fix

* Update test_optimizerlib.py

* Update test_optimizerlib.py

* Update test_optimizerlib.py

* adding multiscale to gp and sparse gp benchmark

* fix

* multiscale out of for loop + fix import

Co-authored-by: Mathurin Videau <[email protected]>
Co-authored-by: Teytaud <[email protected]>
Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Dmitry Vinnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants