Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sam2][frame-loading] Add streaming frame loading on top of lazy loading #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sentfb
Copy link

@sentfb sentfb commented Oct 11, 2024

The AsyncVideoFrameLoader expects image paths to be available ahead of time but loads frames lazily. The Streaming loader does not assume that all inputs are available ahead of time but still loads frames lazily.

Refactored AsyncVideoFrameLoader into a LazyVideoFrameLoader class and extended 2 implementations that are: 1) lazy input + lazy load and 2) eager input + lazy load

@facebook-github-bot
Copy link

Hi @sentfb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sentfb
Copy link
Author

sentfb commented Oct 11, 2024

@raedle, @ronghanghu PTAL and also advise how I can run CI tests for this PR.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants