Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support import in mm_action_prediction/tools/build_multimodal_inputs.py #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-caste
Copy link

@e-caste e-caste commented Dec 30, 2020

The previous import (from tools import support) gave the following error with Python 3.8.5 on Ubuntu 20.04:

Saving dictionary: ../data/simmc_fashion/fashion_vocabulary.json
Saving embeddings: ../data/simmc_fashion/fashion_asset_embeds.npy
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/extract_attribute_vocabulary.py", line 149, in <module>
    extract_action_attributes(parsed_args)
  File "tools/extract_attribute_vocabulary.py", line 41, in extract_action_attributes
    data = np.load(args["train_npy_path"], allow_pickle=True)[()]
  File "/home/$USER/path/simmc/venv/lib/python3.8/site-packages/numpy/lib/npyio.py", line 416, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '../data/simmc_fashion/fashion_train_dials_mm_inputs.npy'

@facebook-github-bot
Copy link

Hi @e-caste!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@e-caste
Copy link
Author

e-caste commented Dec 30, 2020

I have signed the CLA, the automated test should pass now. I think I don't have access to re-run it, so I'll just leave a comment here.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2020
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants