Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix: unexpected list reference issue #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eamonn-zh
Copy link

This is a serious bug, label_to_segs[label].extend(segs) unexpectedly modifies the list in object_id_to_segs[object_id] as segs are assigned to both label_to_segs[label] and object_id_to_segs[object_id] by reference. This results in some segments being assigned the wrong object id.

@facebook-github-bot
Copy link

Hi @eamonn-zh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants