Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: cmd and args #83

Merged
merged 2 commits into from
Apr 28, 2020
Merged

remove: cmd and args #83

merged 2 commits into from
Apr 28, 2020

Conversation

TerminalFi
Copy link
Contributor

@TerminalFi TerminalFi commented Apr 28, 2020

Change Log: Sublime Text: 4074

  • API: Window.new_html_sheet() now accepts the sublime.ADD_TO_SELECTION flag
  • API: Window.new_html_sheet() no longer accepts cmd and args parameters

Fixes

ST 4074+ no longer supports cmd or args
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: API Related to the API. C: source Related to source code. labels Apr 28, 2020
@facelessuser
Copy link
Owner

Docs need this removed as well

@facelessuser
Copy link
Owner

So I assume that instead of cmd and arg the feature relies on subl links?

@gir-bot gir-bot added the C: docs Related to documentation. label Apr 28, 2020
@jrappen
Copy link

jrappen commented Apr 28, 2020

I assume it forces the use of open_url, prohibiting custom solutions.

@facelessuser
Copy link
Owner

Hmm that limits its use some. That kind of sucks. Oh well, it was probably provided for a very specific type of use case though.

@facelessuser
Copy link
Owner

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Apr 28, 2020
@facelessuser facelessuser merged commit dc0abcb into facelessuser:master Apr 28, 2020
@jrappen
Copy link

jrappen commented Apr 28, 2020

@facelessuser I'd appreciate a new release with these changes.

@TheSecEng Thanks. Next time, GitHub requires fixes #82 or closes #82 on its own line for auto-close to work. Fancy readable layouts don't work.

@facelessuser
Copy link
Owner

Yeah, I need to just verify things a bit, prepare the changelog, etc. I'm also in the middle of a move and such, so hopefully today, but we'll see.

@jrappen
Copy link

jrappen commented Apr 28, 2020

No pressure.

@TerminalFi
Copy link
Contributor Author

@facelessuser I'd appreciate a new release with these changes.

@TheSecEng Thanks. Next time, GitHub requires fixes #82 or closes #82 on its own line for auto-close to work. Fancy readable layouts don't work.

Ahh always wondered how it works. Thanks!

@facelessuser
Copy link
Owner

In answer to my own question, you can use subl:cmd links. Not sure there is a way to pass arguments, but that is the best you get it seems.

@facelessuser
Copy link
Owner

Sounds like you can pass arbitrary arguments, I assume in string form so I'll have to evaluate how clever it is, but looks workable.

@jrappen
Copy link

jrappen commented Apr 28, 2020

I think Will said it's in the format subl:cmd { "arg1": "val1", "arg2": "val2" }.

@facelessuser
Copy link
Owner

facelessuser commented Apr 28, 2020

Yup, so that is pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: API Related to the API. C: docs Related to documentation. C: source Related to source code. S: approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants