-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WidgetList component #794
base: main
Are you sure you want to change the base?
WidgetList component #794
Conversation
🔍 Visual review for your branch is published 🔍Here are the links to: |
6230e8c
to
4bedf78
Compare
I have doubts about the approach, but because there is a PR and a lot of work already done, it is hard to share it. What do you think if next time we discuss the approach before writing the code? I see the value in providing the default shell for widget, especially that many of them use this concept of "+n more". At the same time, the current approach relies on setting a maximum height as a way to control the content which does not give us enough sense of the amount of data user will see. I think the height of a widget is depends on the content, meaning the content dictates the height, not the other way around. In addition, the manual calculation of the height is a performance bottleneck, since We already have a bunch of list component and |
I was trying to make a better framework to avoid having to handle in every component the same issues with height, check this comment -> #753 (comment) |
4bedf78
to
4bb350a
Compare
🚪 Why?
Make foundations for a better widget layout
🔑 What?
New component WidgetList
🏡 Context
Screen.Recording.2024-11-05.at.13.33.15.mov