Call setProps only if Tooltip component is not mounted #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were getting errors due to uncancelled timers not getting cleaned up properly when the component unmounted. This resulted in a delayed call to setProps and an error. Unfortunately cancelling the timeouts directly appears to be challenging, so this change introduces a simple `isMountedRef` which is used a guard on calls to setProps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were getting errors due to uncancelled timers not getting cleaned up properly when the component unmounted. This resulted in a delayed call to setProps and an error.
Unfortunately cancelling the timeouts directly appears to be challenging, so this change introduces a simple
isMountedRefwhich is used a guard on calls to setProps.cf. #997