Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #992

Merged
merged 3 commits into from
Jan 26, 2024
Merged

ci: Use GITHUB_OUTPUT envvar instead of set-output command #992

merged 3 commits into from
Jan 26, 2024

Conversation

arunsathiya
Copy link
Contributor

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

@tcbegley
Copy link
Collaborator

Hey, thanks for proposing this and submitting the PR. Apologies it has taken me time to respond, I am quite stretched with other things atm and haven't had much time for this repo.

I like this change and would like to include it. I think this will need some additional changes though to work. See e.g. line 37 where we use the result of set-output. We need to change that to the environment variable.

Can we also use a more descriptive name such as DBC_VERSION or RELEASE_VERSION rather than GITHUB_OUTPUT?

@arunsathiya
Copy link
Contributor Author

No problem, thanks for responding!

See e.g. line 37 where we use the result of set-output. We need to change that to the environment variable.

version stores the value, so that reference/line is okay.

Can we also use a more descriptive name such as DBC_VERSION or RELEASE_VERSION rather than GITHUB_OUTPUT?

The variable/parameter (in the above example, version) is configurable $GITHUB_OUTPUT environment file is not.

@tcbegley
Copy link
Collaborator

Oh! Got it, we're saving key-value pairs to a file specified by the variable, not saving the information to the variable itself 🤦‍♂️.

I clearly need to read things more carefully. Ok great, thanks for this then!

@tcbegley tcbegley merged commit 42e0010 into facultyai:main Jan 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants