Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Location Regressed #682

Closed
jonathansampson opened this issue Aug 8, 2024 · 0 comments · Fixed by #683
Closed

Comments Location Regressed #682

jonathansampson opened this issue Aug 8, 2024 · 0 comments · Fixed by #683

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Aug 8, 2024 •
edited
Loading

This issue has regressed. @jbigman, comments are now in ds:9 again. Perhaps the extractor should check both ds:8 and ds:9 (one being a fallback if the other doesn't contain comments). Thoughts?

Originally posted by @jonathansampson in #603 (comment)
jonathansampson added a commit to jonathansampson/google-play-scraper that referenced this issue Aug 8, 2024
@jonathansampson
dynamically resolves comments path
5f0546b 
fixes facundoolano#682
@jonathansampson jonathansampson mentioned this issue Aug 8, 2024
Merged
jonathansampson added a commit to jonathansampson/google-play-scraper that referenced this issue Aug 8, 2024
@jonathansampson
dynamically resolves comments path
afdef2a 
fixes facundoolano#682

Revert "dynamically resolves comments path"

This reverts commit 5f0546b.

Improves comment extraction

Comments may be found in either ds:8 or ds:9 paths. This approach will check for expected fields in both paths before determine which path houses the comments themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dynamically resolves comments path jonathansampson/google-play-scraper
1 participant
@jonathansampson