Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IReviewsResult to have data attribute rather than reviews #674

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

nick-krantz
Copy link
Contributor

Issue

  • TypeScript shows an error as data doesn't exist on the response of the review endpoint. The current types have reviews but the JS file uses data to supply the reviews array. Updated the TS types here to use data to match.

    Screen Shot 2024-02-14 at 10 39 41 AM

  • It appears that the 10.0.0 version on NPM is out of date with the main branch. Can the latest be deployed?

@facundoolano facundoolano merged commit 2fa6157 into facundoolano:main Feb 14, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants