Add support for Ctrl-C handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuela Hey, thanks for the PR and for feature requests, I have just noticed them. I'll check it a bit later today or tomorrow! |
fadeevab
requested changes
Jan 12, 2024
|
@samuela Alternatively, I can merge this PR and correct it with my additional commit. |
Co-authored-by: Alexander Fadeev <[email protected]>
fadeevab
approved these changes
Jan 17, 2024
|
@samuela merged, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7.
I was hoping that there would be a way to accomplish this without requiring any changes from user code, but I have not yet found a solution to Detegr/rust-ctrlc#106 (comment).
In any case, this PR fixes the issue such that Ctrl-C is now handled the same as Esc, assuming client code sets up a signal handler. Crucially it does not steal the user's cursor anymore.