added getCollectionSize method for mysql mariadb postgres and mongodb… #1
Conversation
|
It works for MySQL, MariaDB and Postgres (I tested it). I don't know about mongodb becuase I tried to use the UTOPIA\MONGO\CLIENT and it is just crashing the server. So I used the MongoDB\Client and made a function to get the size in bytes and it worked so I have implemented a similar thing for the utopia mongo client class. |
src/Database/Adapter/MariaDB.php
Outdated
| throw new Exception("Invalid table name"); | ||
| } | ||
|
|
||
| return (int) $size; |
There was a problem hiding this comment.
Not sure we need the casting? need to be tasted with big numbers..
There was a problem hiding this comment.
changed it to a string.
src/Database/Adapter/Postgres.php
Outdated
| $name = $this->filter($name); | ||
|
|
||
| $query = $this->getPDO()->prepare(" | ||
| SELECT pg_size_pretty(pg_total_relation_size( |
There was a problem hiding this comment.
Please double-check with pg_size_pretty() as we want data in bytes?
There was a problem hiding this comment.
I removed getCollectionSize for Postgres as it works but is giving erros in the tests.
|
Thanks for the review. I will work on it |
No description provided.