-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HONOR needs to be separated from HUAWEI #704
Comments
pinganlong
changed the title
There is a serius bug about Huawei and Honor
There is a serius bug
Jan 23, 2024
faisalman
changed the title
Serious bug feedback
HONOR needs to be separated from HUAWEI
Feb 28, 2024
I can take this up. Can you assign this to me? |
2 tasks
Let me know if any changes are required in the PR! |
When can this problem be fixed? Thanks
…On Tue, 24 Sept 2024, 14:00 Aiyush, ***@***.***> wrote:
Let me know if any changes are required in the PR!
—
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFRIXQORXYJOZU2VBN6TIADZYD5ZFAVCNFSM6AAAAABCGN33ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQGI3DCMZWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Julias0 I've made a change request in the PR before I can merge. @pinganlong Do you perhaps have any data regarding HONOR user agents that we can use for testing? |
I have added the fix in the PR and re-requested a review |
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A clear and concise description of what the bug is.
there is a bug in the open-source project you provided on github (https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L504), the code is as follows.
// Huawei
/\b((?:ag[rs][23]?|bah2?|sht?|btv)-a?[lw]\d{2})\b(?!.+d/s)/i
], [MODEL, [VENDOR, HUAWEI], [TYPE, TABLET]], [
/(?:huawei|honor)([-\w ]+)[;)]/i,
/\b(nexus 6p|\w{2,4}e?-[atu]?[ln][\dx][012359c][adn]?)\b(?!.+d/s)/i
], [MODEL, [VENDOR, HUAWEI], [TYPE, MOBILE]], [
Honor has been re-established as an independent company who got no relation with Huawei. Here are a few reports from 2021 for your ref.
https://www.huawei.com/en/news/2020/11/huawei-honor-statement
https://www.reuters.com/article/uk-huawei-technologies-m-a-digital-china-idUKKBN27W30E
Expected behavior
Honor needs to be separated from Huawei. It is an independent brand, just like other brands // Huawei // Vivo // Realme
The text was updated successfully, but these errors were encountered: