Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HONOR needs to be separated from HUAWEI #704

Closed
pinganlong opened this issue Jan 23, 2024 · 6 comments
Closed

HONOR needs to be separated from HUAWEI #704

pinganlong opened this issue Jan 23, 2024 · 6 comments

Comments

@pinganlong
Copy link

pinganlong commented Jan 23, 2024

Describe the bug
A clear and concise description of what the bug is.

there is a bug in the open-source project you provided on github (https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L504), the code is as follows.

// Huawei
/\b((?:ag[rs][23]?|bah2?|sht?|btv)-a?[lw]\d{2})\b(?!.+d/s)/i
], [MODEL, [VENDOR, HUAWEI], [TYPE, TABLET]], [
/(?:huawei|honor)([-\w ]+)[;)]/i,
/\b(nexus 6p|\w{2,4}e?-[atu]?[ln][\dx][012359c][adn]?)\b(?!.+d/s)/i
], [MODEL, [VENDOR, HUAWEI], [TYPE, MOBILE]], [

Honor has been re-established as an independent company who got no relation with Huawei. Here are a few reports from 2021 for your ref.
https://www.huawei.com/en/news/2020/11/huawei-honor-statement
https://www.reuters.com/article/uk-huawei-technologies-m-a-digital-china-idUKKBN27W30E

Expected behavior
Honor needs to be separated from Huawei. It is an independent brand, just like other brands // Huawei // Vivo // Realme

@pinganlong pinganlong changed the title There is a serius bug about Huawei and Honor There is a serius bug Jan 23, 2024
@pinganlong pinganlong changed the title There is a serius bug Serious bug feedback Jan 23, 2024
@faisalman faisalman changed the title Serious bug feedback HONOR needs to be separated from HUAWEI Feb 28, 2024
@Julias0
Copy link
Contributor

Julias0 commented Sep 23, 2024

I can take this up. Can you assign this to me?

@Julias0
Copy link
Contributor

Julias0 commented Sep 24, 2024

Let me know if any changes are required in the PR!

@pinganlong
Copy link
Author

pinganlong commented Sep 30, 2024 via email

@faisalman
Copy link
Owner

@Julias0 I've made a change request in the PR before I can merge.

@pinganlong Do you perhaps have any data regarding HONOR user agents that we can use for testing?

@Julias0
Copy link
Contributor

Julias0 commented Nov 8, 2024

I have added the fix in the PR and re-requested a review

@faisalman
Copy link
Owner

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@faisalman @Julias0 @pinganlong and others