feat: migrate finance #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
prisis
reviewed
Jan 13, 2022
| * @param min | ||
| * @param max | ||
| * @param dec | ||
| * @param symbol |
prisis
reviewed
Jan 13, 2022
| */ | ||
| currencyCode() { | ||
| return this.faker.random.objectElement( | ||
| this.faker.definitions.finance.currency |
There was a problem hiding this comment.
You can put undefined into it, to fix this error or change the 2 param in objectElement to be optional
prisis
approved these changes
Jan 13, 2022
prisis
reviewed
Jan 13, 2022
src/finance.ts
Outdated
|
|
||
| while (!symbol) { | ||
| symbol = this.faker.random.objectElement( | ||
| this.faker.definitions.finance.currency |
There was a problem hiding this comment.
same as the last comment on this function
|
Maybe we can reuse https://github.com/phuoc-ng/fake-numbers to have correct ibans generated, saw some issues in the old faker |
Shinigami92
force-pushed
the
migrate-finance
branch
from
1a675d7
to
542bde6
Compare
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
damienwebdev
pushed a commit
that referenced
this pull request
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.