Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme.md): api methods table with description #160

Merged
merged 6 commits into from
Jan 19, 2022
Merged

docs(readme.md): api methods table with description #160

merged 6 commits into from
Jan 19, 2022

Conversation

fzn0x
Copy link
Contributor

@fzn0x fzn0x commented Jan 15, 2022

Make ctrl + f over the methods a lot easier on README.

Make ctrl + f over the methods a lot easier on README.
@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 2aca12c

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e7a2c5e322000007c94cc7

😎 Browse the preview: https://deploy-preview-160--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 self-requested a review January 15, 2022 20:32
@Shinigami92
Copy link
Member

There is a rendering issue

image


Beside that, really cool 🙂
Do you want to jump into our Discord Chat on Discord?

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Jan 15, 2022
@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 15, 2022

There is a rendering issue

image

Beside that, really cool 🙂 Do you want to jump into our Discord Chat on Discord?

Spend 3 hours to test all the faker functions, but it's worth it for me since I always use faker for daily basis.

Yes, i will join the discord, my id fndamental#0001.

@Shinigami92
Copy link
Member

Could you also remove the See PR #382 stuff?
image

Then I will approve it 🙌

@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 15, 2022

Could you also remove the See PR #382 stuff? image

Then I will approve it 🙌

Sure, i thought it was on current repository, edited.

Shinigami92
Shinigami92 previously approved these changes Jan 15, 2022
@Shinigami92 Shinigami92 requested a review from a team January 15, 2022 20:53
@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 15, 2022
README.md Outdated Show resolved Hide resolved
@damienwebdev
Copy link
Member

My opinion is that these should be moved to #82 and then rendered in the https://fakerjs.dev docs. While having in the README is nice, as the API expands we'll see that it becomes cumbersome to maintain. I like the descriptions here, perhaps we can move them into the codebase into the Docblocks if there are any methods missing descriptions?

@Shinigami92
Copy link
Member

@damienwebdev I exactly thought the same, but for the short run, this is really nice 👍
We can move it later anyway.

Co-authored-by: Eric Cheng <[email protected]>
@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 16, 2022

I can help with the docblocks, but merge this to another PR will become larger file changes, maybe if I can suggest I can help for the docblocks in different PR or the PR you mentioned.

import-brain
import-brain previously approved these changes Jan 16, 2022
Shinigami92
Shinigami92 previously approved these changes Jan 16, 2022
@Shinigami92 Shinigami92 added this to the v6.0.0 milestone Jan 16, 2022
@Shinigami92 Shinigami92 requested a review from a team January 16, 2022 17:29
@fzn0x fzn0x dismissed stale reviews from Shinigami92 and import-brain via 94e570e January 19, 2022 05:30
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shinigami92 Shinigami92 merged commit bd251ed into faker-js:main Jan 19, 2022
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants