Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix unwrap literal union #1752

Merged
merged 12 commits into from
Jan 26, 2023
Merged

docs: fix unwrap literal union #1752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a063a9
docs: unwrap literal union
ST-DDT Jan 18, 2023
7b9ae7c
chore: apply suggestions
ST-DDT Jan 18, 2023
a8e37a5
chore: attempt to remove readonly
ST-DDT Jan 18, 2023
526b4c9
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 18, 2023
108ffde
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 21, 2023
71320e4
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 22, 2023
e07b498
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 23, 2023
f3a624b
test: update snapshots
ST-DDT Jan 23, 2023
310c78c
docs: wrap functions in parenthesis
ST-DDT Jan 23, 2023
4685797
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 24, 2023
5cf003a
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 24, 2023
4a722db
Merge branch 'next' into docs/unwrap-literal-union
ST-DDT Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/apidoc/signature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,15 @@ function typeToText(type_?: Type, short = false): string {

const type = type_ as SomeType;
switch (type.type) {
case 'array':
return `${typeToText(type.elementType, short)}[]`;
case 'array': {
const text = typeToText(type.elementType, short);
if (text.includes('|')) {
return `(${text})[]`;
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
} else {
return `${text}[]`;
}
}

case 'union':
return type.types
.map((t) => typeToText(t, short))
Expand Down Expand Up @@ -297,6 +304,8 @@ function typeToText(type_?: Type, short = false): string {
)}]`;
case 'literal':
return formatTypescript(type.toString()).replace(/;\n$/, '');
case 'typeOperator':
return `${type.operator} ${typeToText(type.target, short)}`;
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
default:
return type.toString();
}
Expand Down
23 changes: 22 additions & 1 deletion test/scripts/apidoc/__snapshots__/signature.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ exports[`signature > analyzeSignature() > literalUnionParamMethod 1`] = `
"deprecated": false,
"description": "<p>Test with LiteralUnion.</p>
",
"examples": "<div class=\\"language-ts\\"><button title=\\"Copy Code\\" class=\\"copy\\"></button><span class=\\"lang\\">ts</span><pre v-pre class=\\"shiki material-palenight\\"><code><span class=\\"line\\"><span style=\\"color:#A6ACCD\\">faker</span><span style=\\"color:#89DDFF\\">.</span><span style=\\"color:#82AAFF\\">literalUnionParamMethod</span><span style=\\"color:#A6ACCD\\">(value: </span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">a</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">b</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> string): string</span></span>
"examples": "<div class=\\"language-ts\\"><button title=\\"Copy Code\\" class=\\"copy\\"></button><span class=\\"lang\\">ts</span><pre v-pre class=\\"shiki material-palenight\\"><code><span class=\\"line\\"><span style=\\"color:#A6ACCD\\">faker</span><span style=\\"color:#89DDFF\\">.</span><span style=\\"color:#82AAFF\\">literalUnionParamMethod</span><span style=\\"color:#A6ACCD\\">(value: </span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">a</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">b</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> string</span><span style=\\"color:#89DDFF\\">,</span><span style=\\"color:#A6ACCD\\"> namedValue: AB </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> string</span><span style=\\"color:#89DDFF\\">,</span><span style=\\"color:#A6ACCD\\"> array: </span><span style=\\"color:#82AAFF\\">readonly</span><span style=\\"color:#A6ACCD\\"> (</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">a</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#C3E88D\\">b</span><span style=\\"color:#89DDFF\\">'</span><span style=\\"color:#A6ACCD\\"> </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> string)[]</span><span style=\\"color:#89DDFF\\">,</span><span style=\\"color:#A6ACCD\\"> namedArray: </span><span style=\\"color:#82AAFF\\">readonly</span><span style=\\"color:#A6ACCD\\"> (AB </span><span style=\\"color:#89DDFF\\">|</span><span style=\\"color:#A6ACCD\\"> string)[]): string</span></span>
<span class=\\"line\\"></span></code></pre>
</div>",
"name": "literalUnionParamMethod",
Expand All @@ -89,6 +89,27 @@ exports[`signature > analyzeSignature() > literalUnionParamMethod 1`] = `
"name": "value",
"type": "'a' | 'b' | string",
},
{
"default": undefined,
"description": "<p><code>'a'</code> or <code>'b'</code>.</p>
",
"name": "namedValue",
"type": "AB | string",
},
{
"default": undefined,
"description": "<p>Array of <code>'a'</code> or <code>'b'</code>.</p>
",
"name": "array",
"type": "readonly ('a' | 'b' | string)[]",
},
{
"default": undefined,
"description": "<p>Array of <code>'a'</code> or <code>'b'</code>.</p>
",
"name": "namedArray",
"type": "readonly (AB | string)[]",
},
],
"returns": "string",
"seeAlsos": [],
Expand Down
17 changes: 15 additions & 2 deletions test/scripts/apidoc/signature.example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ export interface ParameterOptionsInterfaceC {
value?: number;
}

/**
* A or B.
*/
export type AB = 'a' | 'b';

export class SignatureTest {
/**
* Test with no parameters.
Expand Down Expand Up @@ -128,9 +133,17 @@ export class SignatureTest {
* Test with LiteralUnion.
*
* @param value `'a'` or `'b'`.
* @param namedValue `'a'` or `'b'`.
* @param array Array of `'a'` or `'b'`.
* @param namedArray Array of `'a'` or `'b'`.
*/
literalUnionParamMethod(value: LiteralUnion<'a' | 'b'>): string {
return value;
literalUnionParamMethod(
value: LiteralUnion<'a' | 'b'>,
namedValue: LiteralUnion<AB>,
array: readonly LiteralUnion<'a' | 'b'>[],
namedArray: readonly LiteralUnion<AB>[]
): string {
return value + namedValue + array.join('') + namedArray.join('');
}

/**
Expand Down