Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(phone): deprecate format argument for phone.number #2229

Merged
merged 4 commits into from
Jul 4, 2023
Merged

refactor(phone): deprecate format argument for phone.number #2229

merged 4 commits into from
Jul 4, 2023

Conversation

xDivisionByZerox
Copy link
Member

Closes #1541.

@xDivisionByZerox xDivisionByZerox added s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: phone Something is referring to the phone module deprecation A deprecation was made in the PR labels Jun 29, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team June 29, 2023 09:48
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner June 29, 2023 09:48
@xDivisionByZerox xDivisionByZerox self-assigned this Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #2229 (e190935) into next (5e900d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2229   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2639     2639           
  Lines      245709   245741   +32     
  Branches     1154     1160    +6     
=======================================
+ Hits       244722   244773   +51     
+ Misses        960      941   -19     
  Partials       27       27
Impacted Files Coverage Δ
src/modules/helpers/index.ts 99.09% <100.00%> (ø)
src/modules/phone/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) July 4, 2023 23:27
@ST-DDT ST-DDT merged commit eacab78 into next Jul 4, 2023
38 checks passed
@ST-DDT ST-DDT deleted the refactor/phone/deprecate-format-argument-in-number branch September 11, 2023 21:47
@sheremet-va
Copy link

Is there a reason why this deprecation doesn't mention the migration path? This change is not even mentioned in changelog.

@matthewmayer
Copy link
Contributor

See #2413 where we are discussing how to improve the deprecation message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: phone Something is referring to the phone module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Deprecate phone.number format parameter
5 participants
@xDivisionByZerox @sheremet-va @matthewmayer @ST-DDT @import-brain