Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add da person category #2331

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Conversation

stonor
Copy link
Contributor

@stonor stonor commented Aug 21, 2023

No description provided.

@stonor stonor requested a review from a team as a code owner August 21, 2023 09:32
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2331 (8586e23) into next (d91057d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2331    +/-   ##
========================================
  Coverage   99.60%   99.61%            
========================================
  Files        2721     2735    +14     
  Lines      248549   248991   +442     
  Branches     1082     1090     +8     
========================================
+ Hits       247569   248032   +463     
+ Misses        953      932    -21     
  Partials       27       27            
Files Changed Coverage Δ
src/locales/da/index.ts 100.00% <100.00%> (ø)
src/locales/da/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/da/person/female_middle_name.ts 100.00% <100.00%> (ø)
src/locales/da/person/female_prefix.ts 100.00% <100.00%> (ø)
src/locales/da/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/da/person/index.ts 100.00% <100.00%> (ø)
src/locales/da/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/da/person/last_name_pattern.ts 100.00% <100.00%> (ø)
src/locales/da/person/male_first_name.ts 100.00% <100.00%> (ø)
src/locales/da/person/male_middle_name.ts 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/locales/da/person/female_first_name.ts Outdated Show resolved Hide resolved
src/locales/da/person/name.ts Show resolved Hide resolved
@matthewmayer
Copy link
Contributor

> fakerDA.helpers.multiple(x=>fakerDA.person.fullName(), {count:50})
[
  'Jonathan Birk Abdi',
  'Luna Steffensen',
  'Christopher Krog Beckmann',
  'Uffe Hedegaard',
  'David Husum Dalgaard',
  'Oliver Justesen',
  'Ida Davidsen',
  'Elias Dal Schmidt',
  'Jonathan Schrøder-Munk',
  'Dorit Kjær Bertelsen',
  'Lukas Lorentzen',
  'Laila Frederiksen',
  'Ahmad Holm Thomsen',
  'Elise Fischer-Esbensen',
  'Rasmus Bak',
  'Frida Nygaard',
  'Lisbeth Esbensen',
  'Magnus Bjerre Haugaard',
  'Søren Grøn Frederiksen',
  'Jonas Iversen',
  'Tine Klit Richter',
  'Ida Esbensen',
  'Nicoline Krog Vestergaard',
  'Susanne Hald Juhl',
  'Nadia Fischer',
  'Tim Husum Jensen',
  'Emilie Klausen',
  'Maja Smed Bisgaard',
  'Erik Hald Garcia',
  'Lene Klit Møller',
  'Jørgen Dahl Dalgaard',
  'Mille Mortensen',
  'Adam Villadsen',
  'Silje Nord Mortensen',
  'Lukas Husum Blom',
  'Gry Feldt Frandsen-Johannessen',
  'Thomas Klausen',
  'Dorthe Feldt Brandt',
  'Anders Dal Dupont',
  'Pia Svendsen',
  'Jacob Andersen-Johansen',
  'Annette Bjerg Magnussen',
  'Zara Smed Jespersen',
  'Mark Kjær Jensen',
  'Sebastian Bundgaard Hjorth',
  'Frederik Nissen',
  'Hakim Rasmussen',
  'Poul Bjerg Haugaard',
  'Oscar Beckmann',
  'Hedvig Lund'
]
fakerDA.helpers.multiple(x=>fakerDA.person.fullName({sex:"female"}), {count:50})
[
  'Tine Christiansen',
  'Sandra Buhl',
  'Ruth Mose Kristensen',
  'Bente Frandsen',
  'Nadia Madsen',
  'Viktoria Klit Bang',
  'Nanna Rasmussen',
  'Maja Smed Nygaard',
  'Gitte Buhl',
  'Ruth Haugaard',
  'Alice Karlsen',
  'Alma Munk',
  'Yasmin Pallesen',
  'Britt Jeppesen',
  'Ruth Jespersen',
  'Annette Kjær Fischer',
  'Ella Marcussen',
  'Maren Mose Hjort',
  'Christina Husum Jespersen',
  'Hedvig Holm Kristensen',
  'Louise Birk Pham-Bech',
  'Malene Frost Christensen',
  'Ruth Thomsen',
  'Nadia Koch Christensen',
  'Lillian Krog Iversen',
  'Simone Rosen Dalgaard',
  'Sanne Schrøder',
  'Kirsten Dam Villadsen',
  'Ella Mølgaard Garcia',
  'Luna Østergaard Dahl',
  'Line Bundgaard Kristensen',
  'Johanne Bjerg Pallesen',
  'Lene Jensen',
  'Ditte-Marie Husum Dupont',
  'Marianne Præst Jeppesen',
  'Lisbeth Krog Laursen',
  'Liv Ravn',
  'Louise Smed Buhl',
  'Rebecca Pedersen',
  'Rebecca Kjær',
  'Rosa-Maria Foged',
  'Sofie Vestergaard',
  'Freja Bundgaard Vestergaard',
  'Rosa-Maria Linde Vinther',
  'Josefine Mose Villadsen',
  'Betina Ravn',
  'Laila Marcussen',
  'Camilla Feldt Haugaard',
  'Lillian Lorentzen',
  'Rosa-Maria Mølgaard Jeppesen'
]
> fakerDA.helpers.multiple(x=>fakerDA.person.fullName({sex:"male"}), {count:50})
[
  'Peter Marcussen-Bjerregaard',
  'Steen Vestergaard',
  'John Kristensen',
  'Linus Feldt Lauridsen',
  'Victor Smed Fischer',
  'Magnus Bundgaard Dahl',
  'Per Skov Khan',
  'Lars Marcussen',
  'Adrian Præst Fischer',
  'Jacob Klit Nguyen',
  'Peter Steffensen',
  'Viggo Birk Lorentzen',
  'Jacob Smed Blom',
  'Karl Holm Lauridsen',
  'August Laursen',
  'Philip Johannessen',
  'Ulrik Linde Bruun',
  'Søren Buch',
  'Kurt Mortensen',
  'Viktor Blom',
  'Oliver Khan',
  'Jørgen Nord Dahl',
  'Martin Skov Nygaard',
  'Oscar Kjeldsen',
  'Anton Iversen-Nissen',
  'Ib Jeppesen',
  'Linus Lund',
  'Jan Carlsen',
  'Brian Winther',
  'Ib Smed Lund',
  'Philip Jul Hermansen',
  'Victor Hjort-Bonde',
  'Max Beckmann',
  'Bjørn Østergaard Vinther',
  'Jonathan Jespersen',
  'Christopher Linde Gade',
  'Albert Richter',
  'Patrick Bundgaard Krogh',
  'Uffe Koch Pedersen',
  'Jens Mortensen',
  'Albert Jul Beckmann',
  'Tim Klausen',
  'Brian Smed Richter-Laursen',
  'Stig Østergaard Abdi-Villadsen',
  'Jonas Bjerg Karlsen',
  'Elliot Rasmussen',
  'Mohammad Hedegaard',
  'Jesper Lund Rasmussen-Hjort',
  'Sune Christiansen',
  'Kim Dalgaard'
]

src/locales/da/person/male_middle_name.ts Outdated Show resolved Hide resolved
src/locales/da/person/female_middle_name.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Aug 21, 2023
@ST-DDT ST-DDT requested review from a team August 21, 2023 16:41
@stonor
Copy link
Contributor Author

stonor commented Aug 23, 2023

Hi Matt,

Maybe I'm missing something, but could you explain a bit what kind of change you want me to do before this pull request is ready for merge?

@matthewmayer
Copy link
Contributor

Sorry didn't see it was still blocking. Approved.

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is misleading
You did not add a category to person, you added new data for person in da locale

So please adjust the PR title before merging, but then we are good to go

@ST-DDT ST-DDT enabled auto-merge (squash) August 26, 2023 12:39
@ST-DDT ST-DDT merged commit 466b804 into faker-js:next Aug 26, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants