Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): explicit-length-check #2455

Merged
merged 2 commits into from
Oct 10, 2023
Merged

infra(unicorn): explicit-length-check #2455

merged 2 commits into from
Oct 10, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 9, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 9, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 9, 2023
@ST-DDT ST-DDT requested review from a team October 9, 2023 11:14
@ST-DDT ST-DDT self-assigned this Oct 9, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 9, 2023
Open
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #2455 (82be968) into next (350dfbf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2455   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        2823     2823           
  Lines      255529   255529           
  Branches     1106     1104    -2     
=======================================
  Hits       254478   254478           
  Misses       1023     1023           
  Partials       28       28

see 2 files with indirect coverage changes

xDivisionByZerox
xDivisionByZerox approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collegue of mine whould have loved that rule. Good for consistency 👍

@ST-DDT ST-DDT requested a review from a team October 9, 2023 15:28
@ST-DDT ST-DDT merged commit 6cb5aa2 into next Oct 10, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/explicit-length-check branch October 10, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @matthewmayer @xDivisionByZerox