Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint-define-config #2551

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

Shinigami92
Copy link
Member

Upgrade eslint-define-config to v2.0.0 with new community driven type support system

Currently there is not vitest rules support, I can try add that to vitest directly

@Shinigami92 Shinigami92 added the c: dependencies Pull requests that adds/updates a dependency label Nov 17, 2023
@Shinigami92 Shinigami92 self-assigned this Nov 17, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner November 17, 2023 14:28
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2551 (14d8098) into next (0ee1c67) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2551      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      250088   250088              
  Branches     1099     1099              
==========================================
- Hits       249033   249030       -3     
- Misses       1027     1030       +3     
  Partials       28       28              

see 2 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Nov 17, 2023

Currently there is not vitest rules support, I can try add that to vitest directly

What does that imply for our repository?

@ST-DDT ST-DDT added this to the vAnytime milestone Nov 17, 2023
@Shinigami92
Copy link
Member Author

Currently there is not vitest rules support, I can try add that to vitest directly

What does that imply for our repository?

Nothing special, just that right there is no type-check and auto-completion for vitest rules until they ship support

@ST-DDT ST-DDT enabled auto-merge (squash) November 20, 2023 08:40
@ST-DDT ST-DDT merged commit 9ac8854 into next Nov 20, 2023
20 checks passed
@ST-DDT ST-DDT deleted the update-eslint-define-config branch November 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants