chore(release): 8.4.0

[xDivisionByZerox]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871b2b0) 99.57% compared to head (2468b6c) 99.57%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2606   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2807     2807           
  Lines      250452   250452           
  Branches     1151     1152    +1     
=======================================
+ Hits       249386   249390    +4     
+ Misses       1038     1034    -4     
  Partials       28       28           

see 2 files with indirect coverage changes

[ST-DDT]

Should we wait for #2607 ?
Should we also regenerate the pnpm-lock file as usual?

[matthewmayer]

if you think you'll likely do a 8.4.1 no need to wait. If you plan for 8.4.0 to be final pre-9.0.0 release (barring any critical bugfixes) it would be nice to wait.

[Shinigami92]

IMO it is fine to wait, so that the docs are directly fine and don't need an extra release

[Shinigami92]

https://github.com/faker-js/faker/blob/next/src/modules/finance/index.ts#L379-L612 does not have a @deprecation ⚠️
as well as https://github.com/faker-js/faker/blob/next/src/modules/finance/index.ts#L990-L1167
and https://github.com/faker-js/faker/blob/next/src/modules/location/index.ts#L430-L735

In location.longitude the defaults are wrongly documented, (90 instead of 180)

[xDivisionByZerox]

next/src/modules/finance/index.ts#L379-L612 does not have a @deprecation ⚠️ as well as next/src/modules/finance/index.ts#L990-L1167 and next/src/modules/location/index.ts#L430-L735

In location.longitude the defaults are wrongly documented, (90 instead of 180)

This is what I would put under "if we find anything during the next week", as we discussed in yesterdays meeting. I'd like to release v8.4.0, even if not perfect. Since you already found some unpollished code, we need to release a 8.5.0 as well afterwards.

Opinions on this?

[ST-DDT]

No pnpm-lock update?

[xDivisionByZerox]

No pnpm-lock update?

I never really understood why we do this in the first place.

The lock file ensures that all dependencies work as expected, if installed under the exact conditions described in the file. Why would I ignore that and update it ON RELEASE to potentially introduce a dependency tree that might be broken?
Like it partially happened in the release PR for 8.2.0. While not breaking the dependency tree, the rebuild introduced parts in the file that resolve in the project not being able to build. You are required to manually remove these part. That in itself feels really shady to me.

The lock file should only be updated by renovate or when dependencies are updated manually IMO.