Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-top-level-await #2680

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 22, 2024

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 22, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Feb 22, 2024
@ST-DDT ST-DDT requested review from a team February 22, 2024 18:23
@ST-DDT ST-DDT self-assigned this Feb 22, 2024
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 22, 2024

This PR is way easier to review with "hide whitespace changes".

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (a6eda6f) to head (f7a1b81).

❗ Current head f7a1b81 differs from pull request most recent head 8a1376f. Consider uploading reports for the commit 8a1376f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2680      +/-   ##
==========================================
- Coverage   99.57%   99.55%   -0.03%     
==========================================
  Files        2815     2817       +2     
  Lines      250304   251188     +884     
  Branches     1085     1115      +30     
==========================================
+ Hits       249246   250058     +812     
- Misses       1058     1101      +43     
- Partials        0       29      +29     

see 35 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team February 22, 2024 21:55
@ST-DDT ST-DDT enabled auto-merge (squash) February 25, 2024 21:19
@ST-DDT ST-DDT merged commit c9e8170 into next Feb 25, 2024
14 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-top-level-await branch February 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants