Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(typescript-eslint): consistent-type-exports #2714

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 4, 2024

As suggested here salsita/node-pg-migrate#999 by @Shinigami92


Enables the @typescript-eslint/consistent-type-exports lint rule.

This prevents exports of undefined values in generated code for the types.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 4, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 4, 2024
@ST-DDT ST-DDT requested review from a team March 4, 2024 14:49
@ST-DDT ST-DDT self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (f7471a2) to head (ab9e89e).

❗ Current head ab9e89e differs from pull request most recent head 263959a. Consider uploading reports for the commit 263959a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2714    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2859     2846    -13     
  Lines      249642   248717   -925     
  Branches      645      646     +1     
========================================
- Hits       248575   247671   -904     
- Misses       1038     1046     +8     
+ Partials       29        0    -29     

see 46 files with indirect coverage changes

@Shinigami92 Shinigami92 enabled auto-merge (squash) March 5, 2024 05:08
@Shinigami92 Shinigami92 merged commit 2bf8974 into next Mar 5, 2024
14 checks passed
@ST-DDT ST-DDT deleted the infra/typescript-eslint/consistent-type-exports branch March 5, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants