Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): switch-case-braces #2721

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 5, 2024

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 5, 2024
@ST-DDT ST-DDT requested review from a team March 5, 2024 17:58
@ST-DDT ST-DDT self-assigned this Mar 5, 2024
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 5, 2024

I'm totally unbiased regarding this rule. I just enabled it because it is the default.
I also noticed, that we do actually have both variants (with and without braces) in our code/sometimes even in the same method.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.57%. Comparing base (ade91fd) to head (dc118cd).

❗ Current head dc118cd differs from pull request most recent head 711e7bf. Consider uploading reports for the commit 711e7bf to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2721    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2859     2859            
  Lines      248878   248934    +56     
  Branches      996      631   -365     
========================================
+ Hits       247820   247886    +66     
+ Misses       1029     1019    -10     
  Partials       29       29            
Files Coverage Δ
src/modules/color/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 99.05% <100.00%> (+<0.01%) ⬆️
src/modules/person/index.ts 96.81% <100.00%> (+0.02%) ⬆️
src/modules/string/index.ts 100.00% <100.00%> (ø)
src/modules/system/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/eval.ts 96.56% <85.71%> (-0.38%) ⬇️
src/modules/helpers/index.ts 98.75% <50.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started some month ago to prefer this rule (default) as well

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) March 6, 2024 16:33
@xDivisionByZerox xDivisionByZerox merged commit 2716865 into next Mar 6, 2024
14 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/switch-case-braces branch March 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants