refactor(word): reduce definitions to 1000 in all locales #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2751 +/- ##
==========================================
- Coverage 99.57% 99.50% -0.08%
==========================================
Files 2983 2983
Lines 250340 215303 -35037
Branches 981 984 +3
==========================================
- Hits 249269 214230 -35039
+ Misses 1071 1044 -27
- Partials 0 29 +29
|
|
Please also enable the script cleanup for the word module here: faker/scripts/generate-locales.ts Line 329 in 776a625 |
|
That would cause all other locales to be re-sorted so I will do that in a subsequent PR to avoid making the diff too big. |
ST-DDT
approved these changes
Mar 15, 2024
Shinigami92
approved these changes
Mar 15, 2024
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Follow-on to #2265
Reduced to 1000 entries max in the
wordsmodule definitions in all locales.I selected this module because it had the biggest impact on bundle size (e.g. the
hunoun file alone is approx 144KB, 10K rows.) while still being relatively easy to review.This is a stepping stone to enabling the
normalizeLocaleFilefor all files (previously I noted that I didn't think it was a good idea to try to enable that for all modules at once, as it introduces massive diffs which are impossible to review, and we might accidentally lose useful information, so currently it's only enabled for new modules likefoodbut disabled for existing modules).Even though we dont generally consider editing definitions as semver-major, we may as well make some bundle size improvements in v9 when data is changing anyway as a result of the 53 bit randomizer #2357
Methodology
For any definitions in word module with >1000 entries, I shuffle the array, select 1000 at random and then sort (the sorting is why you see some green in the diffs and not just red)
In total this removes about 530KB from the full bundle.