Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(netlify): fix ignore command #2767

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 23, 2024

This should not have triggered a build:

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c10e09f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/65ff5d71b99a090007d36d2e
😎 Deploy Preview https://deploy-preview-2767.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT self-assigned this Mar 23, 2024
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (ff29421) to head (c10e09f).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2767   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files        2958     2958           
  Lines      213713   213713           
  Branches      948      952    +4     
=======================================
+ Hits       213572   213578    +6     
+ Misses        137      131    -6     
  Partials        4        4           

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Mar 23, 2024
@ST-DDT ST-DDT changed the title docs: fix netlify excludes infra(netlify): fix ignore command Mar 23, 2024
@ST-DDT ST-DDT marked this pull request as ready for review March 23, 2024 22:55
@ST-DDT ST-DDT requested a review from a team as a code owner March 23, 2024 22:55
@ST-DDT ST-DDT requested a review from a team March 23, 2024 22:55
@xDivisionByZerox xDivisionByZerox merged commit df1c83d into next Mar 24, 2024
24 checks passed
@xDivisionByZerox xDivisionByZerox deleted the docs/exclude/tests branch March 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants