feat(animal): add more simple animals to animal.type() #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix faker-js#1618 This adds more common animals and uses more common names for existing ones e.g. cetecean->whale, crocodilia->crocodile
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2786 +/- ##
==========================================
- Coverage 99.94% 99.92% -0.02%
==========================================
Files 2973 2973
Lines 212561 212592 +31
Branches 952 946 -6
==========================================
- Hits 212439 212436 -3
- Misses 118 156 +38
+ Partials 4 0 -4
|
ST-DDT
approved these changes
Apr 5, 2024
import-brain
approved these changes
Apr 5, 2024
Shinigami92
reviewed
Apr 8, 2024
| @@ -194,7 +194,7 @@ export class AnimalModule extends ModuleBase { | |||
| * Returns a random animal type. | |||
There was a problem hiding this comment.
Should we add a warning here, that this is not compatible with faker.animal[faker.animal.type()]()?
Because we have similar use-cases with person.sexType and color.cssSupportedFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1618
This adds more common animals and uses more common names for existing ones e.g. cetecean->whale, crocodilia->crocodile